bump-formula-pr: use nil?/blank?/present? in if statements
#10221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2021-01-05 at 23:33:09 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
reviewed
Jan 5, 2021
| formula ||= determine_formula_from_url(new_url) if new_url | ||
| raise FormulaUnspecifiedError unless formula | ||
| formula ||= determine_formula_from_url(new_url) if new_url.present? | ||
| raise FormulaUnspecifiedError if formula.nil? |
There was a problem hiding this comment.
Suggested change
| raise FormulaUnspecifiedError if formula.nil? | |
| raise FormulaUnspecifiedError if formula.present? |
to be more properly equivalent
There was a problem hiding this comment.
unless formula != if formula.present?
Did you mean blank? ?
| @@ -153,61 +153,64 @@ def bump_formula_pr | |||
|
|
|||
| requested_spec = :stable | |||
| formula_spec = formula.stable | |||
| odie "#{formula}: no #{requested_spec} specification found!" unless formula_spec | |||
| odie "#{formula}: no #{requested_spec} specification found!" if formula_spec.nil? | |||
There was a problem hiding this comment.
Another one I'd suggest just changing to present? In general I'd say always use present? or blank? unless you're wanting to handle nil differently to false.
There was a problem hiding this comment.
This is also a former unless statement
SeekingMeaning
force-pushed
the
bump-formula-nil
branch
from
08781a1
to
64d312c
Compare
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Jan 6, 2021
MikeMcQuaid
approved these changes
Jan 6, 2021
|
Thanks @SeekingMeaning! |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?My brain was having a hard time parsing some of these 馃槄