Skip to content

bump-formula-pr: cleanup#10282

Merged
SeekingMeaning merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:bump-formula-cleanup
Jan 12, 2021
Merged

bump-formula-pr: cleanup#10282
SeekingMeaning merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:bump-formula-cleanup

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

@SeekingMeaning SeekingMeaning commented Jan 10, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This PR includes some general cleanup of brew bump-formula-pr and cleanup of #10221

  • Deleted requested_spec variable since its value is always :stable
  • Moved the check for stable specification to happen earlier
  • Added some missing .present?
  • Fixed strange indentation of check_closed_pull_requests call
  • Replaced duplicate file reads with old_contents

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-01-12 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 10, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 12, 2021
@SeekingMeaning SeekingMeaning merged commit 2e8fe06 into Homebrew:master Jan 12, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 11, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants