Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: pin glibc version to 2.23 #10612

Merged
merged 1 commit into from Feb 26, 2021
Merged

audit: pin glibc version to 2.23 #10612

merged 1 commit into from Feb 26, 2021

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Feb 13, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@BrewTestBot
Copy link
Member

Review period will end on 2021-02-16 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 13, 2021
@iMichka iMichka requested a review from dawidd6 February 13, 2021 16:14
@iMichka
Copy link
Member Author

iMichka commented Feb 13, 2021

Initially I wanted to write a rubocop for this, but as I need formula.version I think this is right place for this check.

MikeMcQuaid
MikeMcQuaid reviewed Feb 15, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Needs thought about how you can ever update glibc without this audit failing, though.

Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 16, 2021
MikeMcQuaid
MikeMcQuaid reviewed Feb 23, 2021
View reviewed changes
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
@iMichka iMichka merged commit 3c3a709 into Homebrew:master Feb 26, 2021
@iMichka iMichka deleted the glibc branch February 26, 2021 16:30
@sjackman
Copy link
Member

Thanks, Michka!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 29, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@sjackman sjackman sjackman approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@dawidd6 dawidd6 dawidd6 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iMichka @BrewTestBot @sjackman @MikeMcQuaid @Bo98 @dawidd6