Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask for sudo when moving Caskroom. #1064

Merged
merged 2 commits into from
Sep 22, 2016
Merged

Ask for sudo when moving Caskroom. #1064

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
458a80d
Ask for `sudo` when moving Caskroom.
reitermarkus Sep 21, 2016
530cee4
Use `sudo mv` to move Caskroom.
reitermarkus Sep 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Library/Homebrew/cask/lib/hbc/caskroom.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ def migrate_caskroom_from_repo_to_prefix
repo_caskroom = Hbc.homebrew_repository.join("Caskroom")
if !Hbc.caskroom.exist? && repo_caskroom.directory?
ohai "Moving Caskroom from HOMEBREW_REPOSITORY to HOMEBREW_PREFIX"

unless Hbc.caskroom.parent.writable?
opoo "#{Hbc.caskroom.parent} is not writable, changing owner to current user."
system "/usr/bin/sudo", "--", "/usr/sbin/chown", "--", "#{Hbc::Utils.current_user}:staff", Hbc.caskroom.parent.to_s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brought me back to when we used to have to do something similar when using /opt.

end

FileUtils.mv repo_caskroom, Hbc.caskroom
end
end
Expand Down