Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_packages: update mediaType. #10978

Merged

Conversation

MikeMcQuaid
Copy link
Member

This custom type will allow better display in GitHub Packages.

This custom type will allow better display in GitHub Packages.
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 31, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

Copy link
Member

@sjackman sjackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than change the mediaType, I'd prefer to use an annotation indicating that it's a Homebrew bottle. Changing the mediaType risks that third-party tools that would otherwise work with our OCI could fail if they validate the mediaType.

@MikeMcQuaid MikeMcQuaid dismissed sjackman’s stale review April 1, 2021 14:05

Further conversation with GitHub here has indicated why they can't use an annotation for this.

@MikeMcQuaid MikeMcQuaid merged commit 8f78b93 into Homebrew:master Apr 1, 2021
@MikeMcQuaid MikeMcQuaid deleted the github_packages_media_type branch April 1, 2021 14:06
@sjackman
Copy link
Member

sjackman commented Apr 1, 2021

After merging this PR, we are unable to use skopeo to copy the resulting OCI image.

$ brew pr-upload --no-commit --github-org=brewsci

Error: Failure while executing; `/usr/local/bin/skopeo copy --all oci:seqkit--0.15.0 docker://ghcr.io/brewsci/bio/seqkit:0.15.0` exited with 1. Here's the output:
Getting image list signatures
Copying 2 of 2 images in list
Copying image sha256:68fa14405fdf83b46275c18c66705a55456b8ba4294a97367164f9182000d3de (1/2)
time="2021-04-01T16:10:37-07:00" level=fatal msg="Error initializing image from source oci:seqkit--0.15.0:: unsupported docker v2s2 media type: \"\""
$ skopeo copy --all oci:seqkit--0.15.0 oci:seqkit--0.15.0.copy
Getting image list signatures
Copying 2 of 2 images in list
Copying image sha256:68fa14405fdf83b46275c18c66705a55456b8ba4294a97367164f9182000d3de (1/2)
FATA[0000] Error initializing image from source oci:seqkit--0.15.0:: unsupported docker v2s2 media type: ""

@github-actions github-actions bot added the outdated PR was locked due to age label May 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants