Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix.sh: repair style #11175

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Apr 17, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

repair prefix.sh style for brew style with shellcheck --enable=all

# TODO: Add `--enable=all` to check for more problems.

related #11086

@@ -2,31 +2,32 @@
# - `brew --prefix` (output HOMEBREW_PREFIX)
# - `brew --prefix <formula>` (output HOMEBREW_PREFIX/opt/<formula>)
# anything else? delegate to the slower cmd/--prefix.rb

# These variables is set by brew.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# These variables is set by brew.sh
# HOMEBREW_PREFIX and HOMEBREW_REPOSITORY are set by brew.sh

@MikeMcQuaid
Copy link
Member

Thanks again @hyuraku!

@MikeMcQuaid MikeMcQuaid merged commit 174b6bd into Homebrew:master Apr 20, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label May 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants