Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_auditor: don't allow bottle :unneeded in core. #11239

Merged
merged 1 commit into from
Jun 29, 2021
Merged

formula_auditor: don't allow bottle :unneeded in core. #11239

merged 1 commit into from
Jun 29, 2021

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Apr 23, 2021

Now we have all: bottles and Bintray is going away for mirrors: let's bottle everything in Homebrew/homebrew-core.

Note: this will fail for now until we've finished bottling these.

Depends on Homebrew/homebrew-core#75943

@BrewTestBot
Copy link
Member

Review period will end on 2021-04-26 at 18:59:36 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 23, 2021
carlocab added a commit to chenrui333/homebrew-core that referenced this pull request Apr 24, 2021
BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Apr 24, 2021
* pmd 6.34.0
* pmd: remove `bottle :unneeded`
  See Homebrew/brew#11239.

Closes #75855.

Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Signed-off-by: Thierry Moisan <thierry.moisan@gmail.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 26, 2021
@BrewTestBot
Copy link
Member

Review period ended.

BrewTestBot
BrewTestBot previously approved these changes Apr 26, 2021
BrewTestBot
BrewTestBot previously approved these changes May 1, 2021
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label May 23, 2021
@Rylan12 Rylan12 added in progress Maintainers are working on this and removed stale No recent activity labels May 23, 2021
BrewTestBot
BrewTestBot previously approved these changes May 31, 2021
BrewTestBot
BrewTestBot previously approved these changes Jun 28, 2021
BrewTestBot
BrewTestBot previously approved these changes Jun 28, 2021
BrewTestBot
BrewTestBot previously approved these changes Jun 28, 2021
Now we have `all:` bottles and Bintray is going away for `mirror`s:
let's bottle everything in Homebrew/homebrew-core.
@MikeMcQuaid MikeMcQuaid merged commit 5a5db3a into Homebrew:master Jun 29, 2021
@MikeMcQuaid MikeMcQuaid deleted the audit_core_bottle_disabled_unneeded branch June 29, 2021 12:23
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Rintel referenced this pull request in Rintel/homebrew-brew Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress Maintainers are working on this outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants