Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit: enable Sublime Text project view #11801

Merged
merged 1 commit into from Aug 3, 2021

Conversation

mistydemeo
Copy link
Member

@mistydemeo mistydemeo commented Aug 1, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Code very similar to this was removed in c6b6fc6 because we had, at the time, moved away from the model where the Homebrew prefix was the repository. Now that we've actually moved back to that model, we've re-inherited exactly the same problems that inspired the original code.

In place of the original code, which specified the list of files to open in cmd/edit, this PR adds a Sublime Text project file and opens that with brew edit instead. That limits the code changes significantly, with the majority of the diff being indent-related. I've left a comment at the top of the Sublime project file to indicate how it was authored.

A similar PR to this was previously open in #10710. This version addresses Mike's comments in the original version.

@BrewTestBot
Copy link
Member

Review period will end on 2021-08-03 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 1, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 3, 2021
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments!

@mistydemeo mistydemeo merged commit ca58ef5 into Homebrew:master Aug 3, 2021
@mistydemeo mistydemeo deleted the edit_enable_project_view branch August 3, 2021 15:28
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants