Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create(go): add -s -w ldflags to reduce the artifact size #11902

Merged
merged 1 commit into from Aug 30, 2021

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Aug 22, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

It is consistent with the go formulae practices we are doing in the homebrew-core

This is the article reference for shrinking the binary (thanks @bayandin)

Signed-off-by: Rui Chen <rui@chenrui.dev>
@BrewTestBot
Copy link
Member

Review period will end on 2021-08-24 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 22, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 24, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@carlocab carlocab merged commit 3947d09 into Homebrew:master Aug 30, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants