Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/update-report: check core tap is installed. #12319

Merged
merged 1 commit into from Oct 25, 2021
Merged

cmd/update-report: check core tap is installed. #12319

merged 1 commit into from Oct 25, 2021

Conversation

MikeMcQuaid
Copy link
Member

Otherwise CoreTap.instance.linuxbrew_core? can fail.

@MikeMcQuaid
cmd/update-report: check core tap is installed.
25e61f6 
Otherwise `CoreTap.instance.linuxbrew_core?` can fail.
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Oct 25, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

iMichka
iMichka reviewed Oct 25, 2021
View reviewed changes
Copy link
Member

@iMichka iMichka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test is still failing

@MikeMcQuaid MikeMcQuaid merged commit 5889b44 into Homebrew:master Oct 25, 2021
@MikeMcQuaid MikeMcQuaid deleted the update-report-check-tap-installed branch October 25, 2021 19:22
@MikeMcQuaid
Copy link
Member Author

Looks like the test is still failing

Think that update-test is running the wrong version so merged regardless.

@Bo98
Copy link
Member

Bo98 commented Oct 25, 2021

It'll be because it's testing between tags I think so this need to go out in a tag to fully fix?

@danielnachun danielnachun mentioned this pull request Oct 26, 2021
Merged
7 tasks
@MikeMcQuaid
Copy link
Member Author

tagged 3.3.1 for this.

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iMichka iMichka iMichka approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikeMcQuaid @BrewTestBot @Bo98 @iMichka