Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottle.rb: fix typo in go regex #12324

Merged
merged 1 commit into from Oct 26, 2021

Conversation

danielnachun
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@danielnachun danielnachun added bug Reproducible Homebrew/brew bug critical Critical change which should be shipped as soon as possible. labels Oct 26, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@danielnachun
Copy link
Member Author

danielnachun commented Oct 26, 2021

There was a typo introduced when I moved the regex for detecting the libexec prefix for go into the formula_ignores method. This breaks the regex and causes brew bottle to incorrectly flag all go dependents as non-relocatable. I'm not sure how many formulae were affected by this, but we should rebottle any that got the wrong cellar. Apologies for this breakage!

First identified here: Homebrew/homebrew-core@56dd835.

danielnachun referenced this pull request in Homebrew/homebrew-core Oct 26, 2021
@danielnachun
Copy link
Member Author

The tap syntax test for Linux fails because of #12319, which may need a new tag before it will be fixed. I'm not sure if auto-merge will work if that fails?

@carlocab carlocab merged commit 000a982 into Homebrew:master Oct 26, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
@danielnachun danielnachun deleted the bottle_regex_fix branch July 11, 2022 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/brew bug critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants