Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linkage to libnss_files.so.2 on Linux #12658

Merged
merged 1 commit into from Jan 2, 2022

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Jan 1, 2022

libnss_nis.so.2 in glibc@2.13 has linkage to libnss_files.so.2.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fix the error

$ brew linkage --test glibc@2.13
Unwanted system libraries:
  /lib/x86_64-linux-gnu/libnss_files.so.2

https://github.com/Homebrew/homebrew-core/runs/4676492184?check_suite_focus=true#step:7:67

libnss_nis.so.2 in glibc@2.13 has linkage to libnss_files.so.2.
@sjackman sjackman self-assigned this Jan 1, 2022
@request-info
Copy link

request-info bot commented Jan 1, 2022

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Jan 1, 2022
@BrewTestBot
Copy link
Member

Review period will end on 2022-01-04 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 1, 2022
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Jan 2, 2022
@iMichka iMichka added the critical Critical change which should be shipped as soon as possible. label Jan 2, 2022
@iMichka iMichka enabled auto-merge January 2, 2022 20:12
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 2, 2022
@iMichka iMichka merged commit a0ae4a7 into Homebrew:master Jan 2, 2022
@iMichka
Copy link
Member

iMichka commented Jan 2, 2022

Let's merge this, it's a minor change, just fixing an audit.

@sjackman sjackman deleted the sj/linkage-checker branch January 3, 2022 17:42
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. needs response Needs a response from the issue/PR author outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants