Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch neither glibc nor glibc@* using patchelf #12661

Merged
merged 2 commits into from Jan 3, 2022
Merged

Patch neither glibc nor glibc@* using patchelf #12661

merged 2 commits into from Jan 3, 2022

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Jan 2, 2022 •
edited

Patching the dynamic linker of Glibc breaks it.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

See PR

@sjackman
Patch neither glibc nor glibc@* using patchelf
2ad3f0a 
Patching the dynamic linker of glibc breaks it.
@sjackman sjackman self-assigned this Jan 2, 2022
@BrewTestBot
Copy link
Member

Review period will end on 2022-01-04 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 2, 2022
@sjackman @carlocab
Use formula_optionally_versioned_regex
06bf91f 
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@sjackman sjackman mentioned this pull request Jan 3, 2022
Closed
6 tasks
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 3, 2022
@MikeMcQuaid
Copy link
Member

Thanks @sjackman!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 3, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit cf0468c into Homebrew:master Jan 3, 2022
@sjackman sjackman deleted the sj/relocate_dynamic_linkage branch January 3, 2022 17:44
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@iMichka iMichka iMichka approved these changes

@danielnachun danielnachun Awaiting requested review from danielnachun

Assignees

@sjackman sjackman

Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sjackman @BrewTestBot @MikeMcQuaid @iMichka @carlocab