Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plist: replace socket and keepalive #93612

Closed
wants to merge 8 commits into from
Closed

plist: replace socket and keepalive #93612

wants to merge 8 commits into from

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@SMillerDev SMillerDev marked this pull request as draft January 22, 2022 15:14
@SMillerDev SMillerDev force-pushed the feature/plist/socket_keepalive branch from e237e8a to dfb80d4 Compare January 25, 2022 13:01
@SMillerDev SMillerDev mentioned this pull request Jan 25, 2022
Merged
7 tasks
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Feb 16, 2022
@SMillerDev
Copy link
Member Author

Hopefully we can merge this soon-ish stalebot

@SMillerDev SMillerDev added in progress Stale bot should stay away and removed stale No recent activity labels Feb 16, 2022
@SMillerDev SMillerDev force-pushed the feature/plist/socket_keepalive branch 2 times, most recently from 49fc9a6 to ec40434 Compare April 27, 2022 19:10
@SMillerDev SMillerDev added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Apr 27, 2022
@SMillerDev SMillerDev force-pushed the feature/plist/socket_keepalive branch 3 times, most recently from 1a82a5a to d0bc0dd Compare May 3, 2022 15:56
@SMillerDev SMillerDev marked this pull request as ready for review May 8, 2022 15:00
@SMillerDev
Copy link
Member Author

Only some connection failure on ubuntu, which nothing changed for

@SMillerDev SMillerDev force-pushed the feature/plist/socket_keepalive branch from d0bc0dd to f408732 Compare May 30, 2022 13:24
@SMillerDev SMillerDev mentioned this pull request May 30, 2022
Closed
38 tasks
@SMillerDev SMillerDev added the CI-no-bottles Merge without publishing bottles label May 30, 2022
@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. in progress Stale bot should stay away outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SMillerDev @BrewTestBot