Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_api: fix PAT URL #13038

Merged
merged 1 commit into from Mar 24, 2022
Merged

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Mar 24, 2022

Ensure that recommended URL matches "scopes required" list. Closes #13030.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2022-03-25 at 02:23:13 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 24, 2022
@Bo98
Copy link
Member

Bo98 commented Mar 24, 2022

Do you have a repo that reproduces this? Feels like something that would only happen to private repositories.

@gromgit
Copy link
Member Author

gromgit commented Mar 24, 2022

Aside from #13030, it happened to me back when (I think) GitHub changed their PAT format. My old Homebrew PAT also had just public_repo scope rather than the overarching repo, and I got the same error after using the regenerated PAT. I eventually had to create a new PAT, but forgot to file a PR to fix this.

And I definitely don't deal with private repos.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 24, 2022
@MikeMcQuaid
Copy link
Member

Thanks again @gromgit!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 24, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit b1577d3 into Homebrew:master Mar 24, 2022
@namnn89

This comment was marked as resolved.

@gromgit
Copy link
Member Author

gromgit commented Mar 24, 2022

@namnn89, note the following:

  1. Please post text output as text, not screenshots. Screen captures are particularly hard to read on mobile platforms.
  2. Your connection to GitHub seems to be failing before the full Homebrew contents can be downloaded. Please read Unable to install: "fatal: the remote end hung up unexpectedly" discussions#666 and see if any of the recommendations there work for you. If not, you should follow up there, not here on a closed PR.

@gromgit gromgit deleted the github_api/fix_url branch March 24, 2022 10:57
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brew audit requires repo scope but link in diagnostic doesn't pre-fill form that way
5 participants