Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: resume checking for TLS 1.3 support #13126

Merged
merged 1 commit into from Apr 12, 2022
Merged

bump: resume checking for TLS 1.3 support #13126

merged 1 commit into from Apr 12, 2022

Conversation

EricFromCanada
Copy link
Member

@EricFromCanada EricFromCanada commented Apr 11, 2022 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

macOS 12.3's shipping curl now supports TLS 1.3, so we can skip installing the curl formula in that case.

@BrewTestBot
Copy link
Member

Review period will end on 2022-04-12 at 22:01:23 UTC.

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Apr 11, 2022
@EricFromCanada
bump: resume checking for TLS 1.3 support
415f05c 
macOS 12.3's shipping curl now supports TLS 1.3.
@EricFromCanada EricFromCanada marked this pull request as ready for review April 12, 2022 03:00
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Apr 12, 2022
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Apr 12, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Apr 12, 2022
@MikeMcQuaid
Copy link
Member

Thanks @EricFromCanada!

@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 12, 2022
@MikeMcQuaid MikeMcQuaid merged commit 8ba4674 into Homebrew:master Apr 12, 2022
@EricFromCanada EricFromCanada deleted the bump-repology-check branch April 12, 2022 12:26
@github-actions github-actions bot added the outdated PR was locked due to age label May 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EricFromCanada @BrewTestBot @MikeMcQuaid @nandahkrishna