Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tap_constants: allow to use underscore in cask names #13177

Merged
merged 1 commit into from Apr 22, 2022
Merged

tap_constants: allow to use underscore in cask names #13177

merged 1 commit into from Apr 22, 2022

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Apr 22, 2022 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR allows using _ in cask names.
_ still is not allowed for homebrews tap casks, should we allow it or we'd like to be a bit more strict about it?

Fixes #13168

@BrewTestBot
Copy link
Member

Review period will end on 2022-04-25 at 11:31:13 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 22, 2022
MikeMcQuaid
MikeMcQuaid approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, thanks for the PR!

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Apr 22, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 22, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@bayandin bayandin merged commit 3f95cdd into Homebrew:master Apr 22, 2022
@bayandin bayandin deleted the allow_underscore_in_cask_names branch April 22, 2022 13:28
@github-actions github-actions bot added the outdated PR was locked due to age label May 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew search fails with error about missing java cask
3 participants
@bayandin @BrewTestBot @MikeMcQuaid