Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?On MacBook Air with M2 chip
brew config
returndunno
family (whilearm_blizzard_avalanche
is expected):And here's the corresponding
sysctl -A
output:It looks like some signed int32 overflow happens somewhere for
0xda33d83d
, which causes it to return a negative number.These changes will also affect CPU family detection for
ARMv8.2-A (Monsoon, Mistral)
(https://en.wikipedia.org/wiki/Apple_A11) and forARMv8.0-A (Twister)
(https://en.wikipedia.org/wiki/Apple_A9 / https://en.wikipedia.org/wiki/Apple_A9X). They are used in iPhones only, so I don't think it will affect anything real.