Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to analytics documentation on brew update. #143

Merged
merged 1 commit into from
Apr 25, 2016
Merged

Point to analytics documentation on brew update. #143

merged 1 commit into from
Apr 25, 2016

Conversation

MikeMcQuaid
Copy link
Member

Make sure that users are notified on the first run of brew update after we enabled analytics about how it works and how to opt-out. This will be shown to all users who have not already seen this message from brew update or through a new Homebrew installation.

References Homebrew/install#42
References #142

@DomT4
Copy link
Member

DomT4 commented Apr 25, 2016

LGTM. There's a small potential to miss the message if you automatically update; perhaps we could detect if update is being run from a tty or something?

Make sure that users are notified on the first run of `brew update`
after we enabled analytics about how it works and how to opt-out. This
will be shown to all users who have not already seen this message from
`brew update` or through a new Homebrew installation.

References Homebrew/install#42
References #142
@MikeMcQuaid
Copy link
Member Author

There's a small potential to miss the message if you automatically update; perhaps we could detect if update is being run from a tty or something?

Good point, done 👍

@MikeMcQuaid MikeMcQuaid merged commit 421cd53 into Homebrew:master Apr 25, 2016
@MikeMcQuaid MikeMcQuaid deleted the analytics-update-message branch April 25, 2016 23:05
@apjanke
Copy link
Contributor

apjanke commented Apr 26, 2016

I saw the update message when I ran brew update tonight. Caught my attention and looks good.

screen shot 2016-04-25 at 8 16 53 pm

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants