Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brew.sh: test HOMEBREW_INSTALL_FROM_API on developers. #14384

Merged
merged 1 commit into from Jan 24, 2023
Merged

brew.sh: test HOMEBREW_INSTALL_FROM_API on developers. #14384

merged 1 commit into from Jan 24, 2023

Conversation

MikeMcQuaid
Copy link
Member

Test HOMEBREW_INSTALL_FROM_API on HOMEBREW_DEV_CMD_RUN and HOMEBREW_DEVELOPER folks who haven't run a HOMEBREW_DEVELOPER_COMMAND.

The next step after this will be to make this functionality the default for everyone.

Want this to be tested a bit before the next major/minor tag but don't want to merge this just yet.

@BrewTestBot
Copy link
Member

Review period will end on 2023-01-19 at 17:49:08 UTC.

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Jan 18, 2023
@BrewTestBot
Copy link
Member

Review period ended.

Rylan12
Rylan12 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MikeMcQuaid
brew.sh: test HOMEBREW_INSTALL_FROM_API on developers.
8e1bcd9 
Test `HOMEBREW_INSTALL_FROM_API` on `HOMEBREW_DEV_CMD_RUN` and
`HOMEBREW_DEVELOPER` folks who haven't run a
`HOMEBREW_DEVELOPER_COMMAND`.

The next step after this will be to make this functionality the default
for everyone.
@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 24, 2023
Closed
14 tasks
@MikeMcQuaid MikeMcQuaid merged commit b8a9fe4 into Homebrew:master Jan 24, 2023
@MikeMcQuaid MikeMcQuaid deleted the homebrew_install_from_api_dev branch January 24, 2023 10:18
@p-linnane
Copy link
Member

Doing some testing on a formula that's failing CI. I'm not able to pass --build-from-source after this change. I've confirmed reverting this commit fixed the issue for me.

@Rylan12
Copy link
Member

Rylan12 commented Jan 24, 2023

That's expected. Building from source is intentionally not supported when using the API. You'll need to set HOMEBREW_NO_INSTALL_FROM_API to use it.

That being said, if there's a messaging issue we should definitely work on improving it

@p-linnane
Copy link
Member

Ah, ok. I misunderstood. I thought setting HOMEBREW_DEVELOPER took care of this. I will set HOMEBREW_NO_INSTALL_FROM_API.

@gibfahn
Copy link
Contributor

gibfahn commented Jan 27, 2023

The next step after this will be to make this functionality the default for everyone.

@MikeMcQuaid for folks maintaining forks of homebrew, is there an issue to track for this feature's rollout? I only just learned about HOMEBREW_INSTALL_FROM_API, and while it seems like a useful thing to have, it will take some time to adapt to 😁

I'd be interested in knowing:

  1. What's the rough plan for when to roll out to everyone by default?
  2. Is the long-term plan to remove support for the non-API way of installing things?
  3. Is the current process in https://github.com/Homebrew/formulae.brew.sh (having homebrew/core and homebrew/cask directly vendored in) the plan going forward as well?

@MikeMcQuaid
Copy link
Member Author

@MikeMcQuaid for folks maintaining forks of homebrew, is there an issue to track for this feature's rollout?

@gibfahn #13794

Will be default in the next few weeks.

I only just learned about HOMEBREW_INSTALL_FROM_API

It was mentioned in https://brew.sh/2022/09/07/homebrew-3.6.0/ and https://brew.sh/2021/10/25/homebrew-3.3.0/. If you're maintaining a fork: you should definitely read all these release notes in detail.

What's the rough plan for when to roll out to everyone by default?

With the next major/minor tag in the next few weeks. Cannot be more specific than that.

Is the long-term plan to remove support for the non-API way of installing things?

No but, for homebrew/core and homebrew/cask stuff: sort of. It'll use the API by default unless you opt-out or build from source (which isn't supported already).

Is the current process in https://github.com/Homebrew/formulae.brew.sh (having homebrew/core and homebrew/cask directly vendored in) the plan going forward as well?

Note sure I understand the question here, can you elaborate?

@rpendleton rpendleton mentioned this pull request Jan 29, 2023
Closed
6 tasks
@apainintheneck apainintheneck mentioned this pull request Jan 30, 2023
Closed
MikeMcQuaid added a commit that referenced this pull request Feb 7, 2023
@MikeMcQuaid
Revert "Merge pull request #14384 from MikeMcQuaid/homebrew_install_f…
1d0779a 
…rom_api_dev"

This reverts commit b8a9fe4, reversing
changes made to daf5b27.
@MikeMcQuaid MikeMcQuaid mentioned this pull request Feb 7, 2023
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MikeMcQuaid @BrewTestBot @p-linnane @Rylan12 @gibfahn