Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "HOMEBREW_INSTALL_FROM_API: make the default for everyone." #14547

Merged
merged 2 commits into from Feb 7, 2023
Merged

Revert "HOMEBREW_INSTALL_FROM_API: make the default for everyone." #14547

merged 2 commits into from Feb 7, 2023

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Feb 7, 2023 •
edited

Reverts #14412
Reverts #14384

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-08 at 14:13:27 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 7, 2023
@MikeMcQuaid MikeMcQuaid added do not merge critical Critical change which should be shipped as soon as possible. labels Feb 7, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 7, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

carlocab
carlocab approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boo. But, if we have to, then ok.

@MikeMcQuaid
Revert "Merge pull request #14384 from MikeMcQuaid/homebrew_install_f…
1d0779a 
…rom_api_dev"

This reverts commit b8a9fe4, reversing
changes made to daf5b27.
@MikeMcQuaid
Copy link
Member Author

Have also pushed a revert of #14384

@MikeMcQuaid MikeMcQuaid merged commit f4e6048 into master Feb 7, 2023
@MikeMcQuaid MikeMcQuaid deleted the revert-14412-homebrew_install_from_api_default branch February 7, 2023 18:11
@glensc
Copy link
Contributor

glensc commented Feb 7, 2023

Revert is related to this issue #14542

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikeMcQuaid @BrewTestBot @glensc @carlocab