cmd/install: fail when pkg not found #14397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This resolves #14361.
The idea here is to facilitate scripting by always failing whenever a package is not installed successfully. This is
how the upgrade and reinstall commands work but not install because we also search for similar package names before terminating.
The only thing to consider here is if anyone relies on the current behavior which would return success if the package didn't exist but a package with a similar name does exist. I can't see how this behavior would be useful for scripting or something you could consistently rely on so I think it's probably fine to change that behavior.
New Behavior