Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet: Update RBI files. #14424

Closed
wants to merge 1 commit into from
Closed

sorbet: Update RBI files. #14424

wants to merge 1 commit into from

Conversation

BrewTestBot
Copy link
Member

Autogenerated by the sorbet workflow.

@MikeMcQuaid
Copy link
Member

@Bo98 hmm, something weird going on here, any ideas?

@dduugg
Copy link
Sponsor Member

dduugg commented Jan 25, 2023

@Bo98 @MikeMcQuaid I think sorbet doesn't like the use of stub_const that was introduced in https://github.com/Homebrew/brew/pull/14418/files#diff-15f572e6ca51666d8e2c7be27c665e0e685a95e8028a295beea217f9151dcb16

Marking Library/Homebrew/test/patching_spec.rb as typed: ignore would work as an immediate band-aid (though it would be the only such file in the repo), as would reverting the PR. It might also be possible to convert the stub_consts into let statements instead. I can take a look when I have a bit more bandwidth available.

@MikeMcQuaid
Copy link
Member

@dduugg Good catch, missed that, too many other PRs floating around in my head just now 😅. Reverting in #14432 for now; we/you can test regenerating RBI files and running brew typecheck on whatever the new solution is. May just be worth using rubocop:disable there instead 🤷🏻

@MikeMcQuaid MikeMcQuaid deleted the sorbet-files-update branch January 26, 2023 11:24
@Bo98
Copy link
Member

Bo98 commented Jan 26, 2023

I think sorbet doesn't like the use of stub_const that was introduced in https://github.com/Homebrew/brew/pull/14418/files#diff-15f572e6ca51666d8e2c7be27c665e0e685a95e8028a295beea217f9151dcb16

Seems what Sorbet is complaining about is correct tbh. stub_const doesn't really make sense for something that's not actually stubbing an existing constant. Looks like it's defining something new which should be a let instead?

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants