Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Enable RSpec/LeakyConstantDeclaration" #14432

Merged
merged 1 commit into from Jan 26, 2023
Merged

Revert "Enable RSpec/LeakyConstantDeclaration" #14432

merged 1 commit into from Jan 26, 2023

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jan 26, 2023 •
edited

Reverts #14418

See #14424 (comment)

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 26, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 26, 2023
Closed
@MikeMcQuaid MikeMcQuaid merged commit 950eb8a into master Jan 26, 2023
@MikeMcQuaid MikeMcQuaid deleted the revert-14418-enable-LeakyConstantDeclaration branch January 26, 2023 11:17
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @BrewTestBot