version: fix bad regexps in version parsers

[carlocab]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

The character class [.-v] is interpreted as all the characters between . and v, which is clearly not what is intended here.

Here's an example of what this fixes. Before:

❯ brew ruby -e 'puts Version.detect("https://github.com/llvm/llvm-project/releases/download/llvmorg-16.0.0-rc1/llvm-project-16.0.0rc1.src.tar.xz")'
6.0.0rc1

After:

❯ brew ruby -e 'puts Version.detect("https://github.com/llvm/llvm-project/releases/download/llvmorg-16.0.0-rc1/llvm-project-16.0.0rc1.src.tar.xz")'
16.0.0rc1

The problem here is that 1 is a match for /[.-v]/.

❯ brew ruby -e 'puts /[.-v]/.match("1")'
1

[BrewTestBot]

Review period will end on 2023-02-02 at 03:03:15 UTC.

[carlocab]

It seems this did use to have /[-.v]/, but was then changed to /[.-v]/ in a52959d through #10433.

I can't find any reasoning for it though, but it seems safe to conclude that the change was not intended.

[MikeMcQuaid]

Makes sense to me 👍🏻

[BrewTestBot]

Review period skipped due to critical label.