Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm 16.0.0rc1 #121953

Closed
wants to merge 4 commits into from
Closed

llvm 16.0.0rc1 #121953

wants to merge 4 commits into from

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Plus, while we're here, some small improvements.

@carlocab carlocab added do not merge prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies long build Needs CI-long-timeout labels Jan 31, 2023
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 31, 2023
carlocab
carlocab commented Jan 31, 2023
View reviewed changes
Formula/llvm.rb Outdated
url "https://github.com/llvm/llvm-project/releases/download/llvmorg-15.0.7/llvm-project-15.0.7.src.tar.xz"
sha256 "8b5fcb24b4128cf04df1b0b9410ce8b1a729cb3c544e6da885d234280dedeac6"
url "https://github.com/llvm/llvm-project/releases/download/llvmorg-16.0.0-rc1/llvm-project-16.0.0rc1.src.tar.xz"
version "16.0.0rc1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our version parser is picking this up at 6.0.0rc1, which is wrong.

The errant parser seems to be this one.

    # e.g. https://registry.npmjs.org/@angular/cli/-/cli-1.3.0-beta.1.tgz
    # e.g. https://github.com/dlang/dmd/archive/v2.074.0-beta1.tar.gz
    # e.g. https://github.com/dlang/dmd/archive/v2.074.0-rc1.tar.gz
    # e.g. https://github.com/premake/premake-core/releases/download/v5.0.0-alpha10/premake-5.0.0-alpha10-src.zip
    StemParser.new(/[.-vV]?(#{NUMERIC_WITH_DOTS}#{PRERELEASE_SUFFIX})/),

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Homebrew/brew#14471

@carlocab carlocab added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Feb 1, 2023
@cho-m cho-m added CI-long-timeout Use longer GitHub Actions CI timeout. CI-linux-self-hosted Build on Linux self-hosted runner and removed CI-long-timeout Use longer GitHub Actions CI timeout. labels Feb 3, 2023
@carlocab
Copy link
Member Author

carlocab commented Feb 7, 2023

To-do: see if we can ship a configuration file instead of setting -DDEFAULT_SYSROOT. That'll allow Xcode-only systems to install bottles too.

https://clang.llvm.org/docs/UsersManual.html#configuration-files

@carlocab
llvm: various improvements
cae57fc 
1. Remove unnecessary flags
2. Tighten matching of LLVM bitcode
3. Improve tests
@carlocab
llvm 16.0.0rc1
c94213d
@carlocab
llvm: update alias
82021c4
@carlocab
llvm: add audit exception for RC1
eef09be
@carlocab
Copy link
Member Author

To-do: see if we can ship a configuration file instead of setting -DDEFAULT_SYSROOT. That'll allow Xcode-only systems to install bottles too.

https://clang.llvm.org/docs/UsersManual.html#configuration-files

We can set CLANG_CONFIG_FILE_SYSTEM_DIR, but this will break relocatability of the bottles because this will hardcode some path inside HOMEBREW_PREFIX. I'm planning to upstream a patch that will allow us to use a relative path, but this will probably take me a while.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Mar 7, 2023
@github-actions github-actions bot closed this Mar 16, 2023
@ZhongRuoyu
Copy link
Member

16.0.0 is out. Time to resurrect this, maybe?

@carlocab
Copy link
Member Author

Pushed the important changes to #126023.

@carlocab carlocab deleted the llvm-16 branch March 18, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long build Needs CI-long-timeout prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlocab @ZhongRuoyu @BrewTestBot @cho-m