Bash completions: cache names of 'doctor' checks

[maxim-belkin]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

I propose to cache names of brew doctor checks the first time the list of the checks is obtained. Also, reuse _brew_doctor function for brew dr (and, hence, remove _brew_dr function which is a duplicate of _brew_doctor).

It seems that some work has been done for Bash completions to be generated "automatically" using brew generate-man-completions. Not sure how this PR is going to affect that effort, so tagging in @Rylan12.

[BrewTestBot]

Review period will end on 2023-02-07 at 00:00:00 UTC.

[Rylan12]

Yeah, as-is I think brew generate-man-completions will overwrite these changes. You might be able to edit the generation code in Completions to get this to work, but tbh it's been a really long time since I've looked at these so I don't remember the intricacies that well anymore.

[maxim-belkin]

Yeah, as-is I think brew generate-man-completions will overwrite these changes. You might be able to edit the generation code in Completions to get this to work, but tbh it's been a really long time since I've looked at these so I don't remember the intricacies that well anymore.

I suggest to improve Bash completions first (e.g., cache completions) and then, if either one of us gets to generate-man-completions -- fix that one to make it generate similar results. Currently, brew generate-man-completions fails for me with the following message:

$ brew generate-man-completions -vd
Writing markdown to /opt/homebrew/docs/Manpage.md
Error: Broken pipe

[MikeMcQuaid]

I suggest to improve Bash completions first (e.g., cache completions) and then, if either one of us gets to generate-man-completions -- fix that one to make it generate similar results.

Sorry, we're not going to merge something that's going to get immediately reverted by an automated PR.

[maxim-belkin]

Oh, so changes made to Bash completions are not going to persist unless they're implemented in (some other) files that generate them. This makes me suspect that changes I made in #14467 will be overwritten the next time Bash completions are updated.

[Rylan12]

Yeah, looks like it was removed in #14513

[maxim-belkin]

That was fast :/ OK, I'll look for a proper place to implement these changes. The fact that generate-man-completions fails on my machine is not helping but... oh, well!

[maxim-belkin]

Converting to a draft for now as more changes are needed

[BrewTestBot]

Review period ended.

[MikeMcQuaid]

@maxim-belkin what's the latest here?

[maxim-belkin]

@maxim-belkin what's the latest here?

Thanks for the reminder, @MikeMcQuaid. PR is ready for your and @Rylan12's review.

I also fixed syntax of the case command. I can do it in a separate PR -- just let me know.

[MikeMcQuaid]

Thanks @maxim-belkin! Unfortunately looks like some legit/related test failures here.

[maxim-belkin]

Thanks @maxim-belkin! Unfortunately looks like some legit/related test failures here.

Yep. I fixed one test yesterday but didn't notice the other one a few lines of code down.

[MikeMcQuaid]

Thanks again @maxim-belkin!

[maxim-belkin]

Thanks for merging it in, Mike!