Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash completions: cache names of 'doctor' checks #14507

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Bash completions: cache names of 'doctor' checks #14507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3da5a3
Bash completions: cache names of 'doctor' checks
maxim-belkin Feb 24, 2023
5382774
Update Bash completion tests
maxim-belkin Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Library/Homebrew/completions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ module Completions
tap: "__brew_complete_tapped",
installed_tap: "__brew_complete_tapped",
command: "__brew_complete_commands",
diagnostic_check: '__brewcomp "$(brew doctor --list-checks)"',
diagnostic_check: '__brewcomp "${__HOMEBREW_DOCTOR_CHECKS=$(brew doctor --list-checks)}"',
file: "__brew_complete_files",
}.freeze

Expand Down Expand Up @@ -187,7 +187,7 @@ def generate_bash_subcommand_completion(command)
"
return
;;
*)
*) ;;
esac#{named_completion_string}
}
COMPLETION
Expand Down
4 changes: 2 additions & 2 deletions Library/Homebrew/test/completions_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def delete_completions_setting(setting: "linkcompletions")
"
return
;;
*)
*) ;;
esac
__brew_complete_formulae
}
Expand All @@ -287,7 +287,7 @@ def delete_completions_setting(setting: "linkcompletions")
"
return
;;
*)
*) ;;
esac
}
COMPLETION
Expand Down