Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formulary: respect HOMEBREW_BOTTLE_DOMAIN when installing from API #14544

Merged
merged 1 commit into from Feb 7, 2023

Conversation

XuehaiPan
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Respect HOMEBREW_BOTTLE_DOMAIN when installing from API. This will cause downloading from HOMEBREW_BOTTLE_DOMAIN first when falling back to the default bottle domain if fail.

@Bo98
Copy link
Member

Bo98 commented Feb 7, 2023

This makes sense, thanks!

I wonder though, could it be simplified to:

if bottles_stable["root_url"] != HOMEBREW_BOTTLE_DEFAULT_DOMAIN
  root_url bottles_stable["root_url"]
end

?

@MikeMcQuaid MikeMcQuaid merged commit 66fe57e into Homebrew:master Feb 7, 2023
@MikeMcQuaid
Copy link
Member

Thanks again @XuehaiPan!

@XuehaiPan XuehaiPan deleted the api-bottle-domain branch February 7, 2023 13:57
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants