dev-cmd/contributions: Count PR reviews since they're super important #14813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The search APIs don't have that high a rate limit but we shouldn't need to worry about that too much because, to get counts, the JSON response comes with a `total_count` number.
|
Review period will end on 2023-02-28 at 00:00:00 UTC. |
BrewTestBot
added
the
waiting for feedback
Test failure:
```
Failure/Error:
expect(described_class.search_taps("some-formula"))
.to match(formulae: ["homebrew/foo/some-formula"], casks: ["homebrew/bar/some-cask"])
GitHub::API asked to yield |[{"items"=>[{"path"=>"Formula/some-formula.rb", "repository"=>{"full_name"=>"Homebrew/homebrew-foo"}}, {"path"=>"Casks/some-cask.rb", "repository"=>{"full_name"=>"Homebrew/homebrew-bar"}}]}]| but no block was passed
```
issyl0
force-pushed
the
contributions-approvals
branch
from
2b4a1bb
to
99d2bb9
Compare
nandahkrishna
approved these changes
Feb 26, 2023
issyl0
added
the
critical
BrewTestBot
removed
the
waiting for feedback
|
Review period skipped due to |
BrewTestBot
approved these changes
Feb 26, 2023
7 tasks
MikeMcQuaid
reviewed
Feb 27, 2023
| @@ -173,6 +175,7 @@ def scan_repositories(repos, person, args) | |||
| commits: GitHub.repo_commit_count_for_user(repo_full_name, person, args), | |||
| coauthorships: git_log_trailers_cmd(T.must(repo_path), person, "Co-authored-by", args), | |||
| signoffs: git_log_trailers_cmd(T.must(repo_path), person, "Signed-off-by", args), | |||
| reviews: GitHub.count_issues("", is: "pr", repo: repo_full_name, reviewed_by: person), | |||
There was a problem hiding this comment.
Definitely wouldn't have been blocking: is there any way to query the specific type of reviews?
There was a problem hiding this comment.
A query like is:pr reviewed-by:#{user} review:approved works to get approvals by the user, but we can't combine review:approved and review:changes_requested. So I thought that just reviewed-by:#{user} was safest to encompass everything.
There was a problem hiding this comment.
@issyl0 I'd consider filtering this to just review:approved as it'll get fewer results, requires write access (i.e. "maintainer duties") and is required to move things forward. Thoughts?
issyl0
added a commit
to issyl0/brew
that referenced
this pull request
Feb 27, 2023
- The `reviewed-by` filter retrieved all reviews for a user, including those they'd added to their own PRs. Since it's impossible to click the "approve" button on one's own PR, filter this to `review:approved` to get "further project goals" kinds of reviews. - Suggested in Homebrew#14813 (comment). - Shorten a variable name so I didn't have to split the `count_issues` call onto multiple lines since the indentation looked funky when I tried it.
7 tasks
issyl0
added a commit
to issyl0/brew
that referenced
this pull request
Feb 28, 2023
- The `reviewed-by` filter retrieved all reviews for a user, including those they'd added to their own PRs. Since it's impossible to click the "approve" button on one's own PR, filter this to `review:approved` to get "further project goals" kinds of reviews. - Suggested in Homebrew#14813 (comment).
issyl0
added a commit
to issyl0/brew
that referenced
this pull request
Feb 28, 2023
- The `reviewed-by` filter retrieved all reviews for a user, including those they'd added to their own PRs. Since it's impossible to click the "approve" button on one's own PR, filter this to `review:approved` to get "further project goals" kinds of reviews. - Suggested in Homebrew#14813 (comment).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew contributions. #13642.total_countnumber.