Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/contributions: Only count approving reviews #14823

Merged
merged 1 commit into from Feb 28, 2023
Merged

dev-cmd/contributions: Only count approving reviews #14823

merged 1 commit into from Feb 28, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 27, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • The reviewed-by filter retrieved all reviews for a user, including those they'd added to their own PRs. Since it's impossible to click the "approve" button on one's own PR, filter this to review:approved to get "further project goals" kinds of reviews.
  • Suggested in dev-cmd/contributions: Count PR reviews since they're super important #14813 (comment).
  • Shorten a variable name so I didn't have to split the count_issues call onto multiple lines since the indentation looked funky when I tried it.

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-28 at 13:14:56 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 27, 2023
MikeMcQuaid
MikeMcQuaid reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! One tiny naming nit.

Library/Homebrew/dev-cmd/contributions.rb Outdated Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member

Thanks again @issyl0!

@issyl0 issyl0 force-pushed the contributions-reviews-approved branch from 39f87e3 to e93ebef Compare February 28, 2023 11:17
@MikeMcQuaid
Copy link
Member

@issyl0 Has merge conflicts but good to auto-merge afters!

@issyl0
dev-cmd/contributions: Only count approving reviews
b8b7e63 
- The `reviewed-by` filter retrieved all reviews for a user, including
  those they'd added to their own PRs. Since it's impossible to click
  the "approve" button on one's own PR, filter this to `review:approved`
  to get "further project goals" kinds of reviews.
- Suggested in Homebrew#14813 (comment).
@issyl0 issyl0 force-pushed the contributions-reviews-approved branch from e93ebef to b8b7e63 Compare February 28, 2023 12:58
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 28, 2023
@MikeMcQuaid
Copy link
Member

Thanks again @issyl0!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 28, 2023
@BrewTestBot
Copy link
Member

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit 70d3417 into Homebrew:master Feb 28, 2023
@issyl0 issyl0 deleted the contributions-reviews-approved branch February 28, 2023 13:31
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@issyl0 @BrewTestBot @MikeMcQuaid