rubocop: Further trim Naming/MethodParameterName allowlist
#14944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This either stands for "file" but more often than not "formula".
- I couldn't figure out what this would stand for, so I asked on Slack if anyone had better ideas otherwise I'd go with "ostrich" or "octopus". Rylan suggested "option", which is very sensible.
|
Review period will end on 2023-03-14 at 00:00:00 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
added
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Mar 11, 2023
MikeMcQuaid
reviewed
Mar 11, 2023
| "f", | ||
| "o", | ||
| "pr", | ||
| "pr", # TODO: Remove if https://github.com/rubocop/rubocop/pull/11690 is merged or we change the variable names. |
There was a problem hiding this comment.
Might want to move f to another PR so the tap syntax changes don't block this one?
issyl0
added a commit
to issyl0/homebrew-bundle
that referenced
this pull request
Mar 11, 2023
- Part of Homebrew/brew#14944. - This stands for "formula".
issyl0
added a commit
to issyl0/homebrew-bundle
that referenced
this pull request
Mar 11, 2023
- Part of Homebrew/brew#14944. - This stands for formula.
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew typecheckwhich caught some occurrences I hadn't picked up, I ranbrew testswhich caught some more, and I ranbrew stylewhich caught even more. Worth a second set of eyes though?