New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorbet: Autogenerate the RBI file for Homebrew::EnvConfig
#14950
Merged
MikeMcQuaid
merged 8 commits into
Homebrew:master
from
issyl0:sorbet-autogenerate-envconfig-rbi
Mar 13, 2023
Merged
sorbet: Autogenerate the RBI file for Homebrew::EnvConfig
#14950
MikeMcQuaid
merged 8 commits into
Homebrew:master
from
issyl0:sorbet-autogenerate-envconfig-rbi
Mar 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I'm not as happy with this as I was with my work on `utils/tty.rb`, it feels a lot hackier and prone to breaking - especially the `T.nilable` "detection". - However, it generates an RBI file that passes `brew typecheck`, so we can clean up some `hidden-definitions` entries, getting further towards fully typed.
Review period will end on 2023-03-14 at 00:00:00 UTC. |
BrewTestBot
added
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Mar 11, 2023
7 tasks
Co-authored-by: Markus Reiter <me@reitermark.us>
issyl0
commented
Mar 13, 2023
Thanks for the review and the fixes, @reitermarkus! ✨ |
reitermarkus
approved these changes
Mar 13, 2023
MikeMcQuaid
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, thanks again @issyl0!
MikeMcQuaid
added
the
critical
Critical change which should be shipped as soon as possible.
label
Mar 13, 2023
BrewTestBot
removed
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Mar 13, 2023
Review period skipped due to |
BrewTestBot
approved these changes
Mar 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?utils/tty.rb
, it feels a lot hackier and prone to breaking - especially theT.nilable
"detection".brew typecheck
, so we can clean up somehidden-definitions
entries, getting further towards fully typed.