Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check CUSTOM_IMPLEMENTATIONS for all variables. #14951

Merged
merged 1 commit into from Mar 12, 2023
Merged

Check CUSTOM_IMPLEMENTATIONS for all variables. #14951

merged 1 commit into from Mar 12, 2023

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Noticed this while reviewing #14950.

@BrewTestBot
Copy link
Member

Review period will end on 2023-03-14 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 12, 2023
MikeMcQuaid
MikeMcQuaid approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks!

@MikeMcQuaid MikeMcQuaid added critical Critical change which should be shipped as soon as possible. and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Mar 12, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 1ff9835 into Homebrew:master Mar 12, 2023
@reitermarkus reitermarkus deleted the env-config branch March 13, 2023 01:43
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reitermarkus @BrewTestBot @MikeMcQuaid