Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/cask: Fix "System Settings" caveats for (non-)Ventura OSes #15001

Merged
merged 2 commits into from Mar 18, 2023
Merged

test/cask: Fix "System Settings" caveats for (non-)Ventura OSes #15001

merged 2 commits into from Mar 18, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Mar 18, 2023 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • "System Preferences" was updated to be "System Settings" in macOS Ventura. This naming was updated in our caveats generator in Update path to system settings on Ventura #14997
  • This test was failing for me locally (on Ventura) because it was hardcoded to expect System Preferences => Security & Privacy, but getting System Settings => Privacy & Security.
  • This is not the most important thing in the world, we can probably live with the failing test (it didn't fail when this was initially implemented?), but I thought I'd try to fix it anyway.

@issyl0
test/cask: Fix "System Settings" caveats for (non-)Ventura OSes
6b4b923 
- "System Preferences" was updated to be "System Settings" in macOS
  Ventura. This naming was updated in our caveats generator in PR 14997.
- This test was failing for me locally (on Ventura) because it was
  hardcoded to expect `System Preferences => Security & Privacy`, but
  getting `System Settings => Privacy & Security`.
- This is not the most important thing in the world, we can probably
  live with the failing test, but I thought I'd try to fix it anyway.
@BrewTestBot
Copy link
Member

Review period will end on 2023-03-21 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 18, 2023
Rylan12
Rylan12 approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to rename this since it will apply to all future macOS versions as well (I assume) and not just ventura.

But otherwise 👍

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Mar 18, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 18, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@issyl0
test/cask: Rename 'expected_json_ventura' since it's >= Ventura
865e99c 
- Let's actually show in the fixtures JSON filename what's changed
  between the two.
Rylan12
Rylan12 approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Rylan12 Rylan12 enabled auto-merge March 18, 2023 15:18
@Rylan12 Rylan12 merged commit 5550aa2 into Homebrew:master Mar 18, 2023
22 checks passed
@issyl0 issyl0 deleted the cask-tests-fix-for-ventura branch March 18, 2023 15:46
@apainintheneck
Copy link
Contributor

Good catch! I wrote this test on a Mac that doesn't run on Ventura so that's why I didn't catch it originally.

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@issyl0 @BrewTestBot @apainintheneck @Rylan12