Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask: remove old prefix placeholder #15009

Merged

Conversation

apainintheneck
Copy link
Contributor

This was just a temporary workaround while we
waited for the API to regenerate the JSON content.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is just a follow-up to changing the prefix placeholder for casks in #14615. It should be fine now since it's been around a month since the original PR and the API JSON gets reloaded for users every day or so. There is an edge case where someone is on the most recent brew version but has a really old cask.json file but I doubt that's worth worrying about.

This was just a temporary workaround while we
waited for the API to regenerate the JSON content.
@BrewTestBot
Copy link
Member

Review period will end on 2023-03-21 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 18, 2023
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this earlier and wondered when the TODO was written. Good cleanup!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup and sorry for missing this @apainintheneck!

@MikeMcQuaid MikeMcQuaid merged commit c5fa3d2 into Homebrew:master Mar 19, 2023
21 of 23 checks passed
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 19, 2023
@apainintheneck apainintheneck deleted the remove-old-prefix-placeholder branch March 24, 2023 03:25
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants