Commits on Apr 11, 2023

1. Don't save mac metadata/extended attributes for brew bottle …

   This commit includes `--no-mac-metadata` `--no-acls` and `--no-xattrs`
   in `default_tar_args` for `brew bottle` command.
   
   Although `default_tar_args` is only active when `--only-json-tab` is
   not passed, in which case we don't require reproducible bottles, it is
   nonetheless beneficial to "regularize" tarball creation. In
   particular, this resolves a sporadic `brew tests
   --only=dev-cmd/bottle:20` failure (see
   https://github.com/orgs/Homebrew/discussions/4376 and
   Homebrew#14997).
   
   Furthermore, with `gnu tar`, `--no-acls` and `--no-xattrs` are default
   flags. As for "mac metadata", although I couldn't find official
   documentation, this post (https://superuser.com/a/61188) shares some
   info:
   - Resource forks (resource forks have been extended attributes since 10.4)
     - Custom icons set in Finder and the images of Icon\r files
     - Metadata in PSD files
     - Objects stored in scpt files, AppleScript Editor window state, descriptions of scripts
   - Information about aliases (aliases stop working if extended attributes are removed)
   - Quarantine status or source URLs of files downloaded from the internet
   - Spotlight comments
   - Encoding of files saved with TextEdit
   - Caret position of files opened with TextMate
   - Skim notes
   
   None of these is supposed to be in the bottle I believe.

   

   ywwry66 committed Apr 11, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for d7427ab
   • Browse repository at this point

   Copy the full SHA

   d7427ab View commit details

   Browse the repository at this point in the history

2. dev-cmd/bottle: Refactor setup_tar_and_args! to extend/os

   

   ywwry66 committed Apr 11, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 73a1380
   • Browse repository at this point

   Copy the full SHA

   73a1380 View commit details

   Browse the repository at this point in the history