Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SubversionDownloadStrategy#source_modified_time #156

Merged
merged 1 commit into from Apr 29, 2016

Conversation

vladshablinsky
Copy link
Contributor

@vladshablinsky vladshablinsky commented Apr 27, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully ran brew tests with your changes locally?

Description

Implement SubversionDownloadStrategy#source_modified_time from #81

@MikeMcQuaid
Copy link
Member

Looks good to me 👍 @xu-cheng, any thoughts?

@xu-cheng xu-cheng merged commit 3ff1aa9 into Homebrew:master Apr 29, 2016
@xu-cheng
Copy link
Member

xu-cheng commented Apr 29, 2016

LGTM. Sorry for late response

@vladshablinsky vladshablinsky deleted the svn_source_modified_time branch April 30, 2016 22:21
@UniqMartin
Copy link
Contributor

Sorry for the late comment! I wonder to what extent #171 (comment) is also applicable here and whether it would be a good idea to extract the information from svn info --xml instead …

@xu-cheng
Copy link
Member

xu-cheng commented May 1, 2016

cc @vladshablinsky

svn info --xml seems to be a better approach. You can parse XML using REXML::XPath.
e.g.

require "rexml/document"
xml = REXML::Document.new(Utils.popen_read("svn", "info", "--xml", cached_location.to_s))
Time.parse REXML::XPath.first(xml, "//date/text()")

@vladshablinsky vladshablinsky restored the svn_source_modified_time branch May 1, 2016 09:46
@vladshablinsky
Copy link
Contributor Author

vladshablinsky commented May 1, 2016

@xu-cheng I knew about this option and thought that REXML does pretty much the same things like regular expression matching. However it could be more flexible if svn's log output changes in new versions, so I'll open a new PR. Thanks!

@UniqMartin seems there is no way to change the date output format.

@UniqMartin UniqMartin added the gsoc-outreachy Google Summer of Code or Outreachy label Jun 22, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gsoc-outreachy Google Summer of Code or Outreachy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants