Override VCSDownloadStrategy#source_modified_time

[vladshablinsky]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully ran brew tests with your changes locally?

Detaills

Implement

• MercurialDownloadStrategy#source_modified_time
• BazaarDownloadStrategy#source_modified_time
• FossilDownloadStrategy#source_modified_time

from #81

Bazaar

bzr log -l 1 has the following format:

➜ vlad:bazimport$ bzr log -l 1
------------------------------------------------------------
revno: 663
committer: Aaron Bentley <aaron@aaronbentley.com>
branch nick: bazimport
timestamp: Thu 2008-10-23 18:04:00 +0100
message:
  Fix import with existing revisions

Mercurial

hg tip has the following format:

➜ vlad:SDL_rtf$ hg tip
changeset:   66:c0f87ece5d47
tag:         tip
user:        Sam Lantinga <slouken@libsdl.org>
date:        Sat Jan 02 10:54:19 2016 -0800
summary:     Updated copyright to 2016

hg log -l 1 also possible, but hg tip seems to be better.

Fossil

fossil info tip -R <repo> has the following format:

➜ vlad:fossil$ fossil info tip -R fossil
uuid:         7c4628a568c01a11642e18c119c93aa1d85632ed 2016-04-29 10:28:21 UTC
parent:       6f35075ad72b8608bd5ce2fccf093495331d1187 2016-04-29 08:28:27 UTC
tags:         trunk
comment:      Make options --repolist and --baseurl work together, if the original URL doesn't end with '/'. (user: jan.nijtmans)

[MikeMcQuaid]

LGTM 👍 @xu-cheng?

[UniqMartin]

Not being very familiar with the listed tools, is there some way to make them output the time in a more standardized way (e.g. ISO 8601, RFC 2822) like we do with the Git download strategy? It would be a pity if parsing failed because of version-dependent changes in the human-readable output format that is currently being parsed or if the time format adapts to the user's locale. Have you checked what happens when you set, e.g., LC_ALL=de_DE.UTF-8 prior to invocation?

[vladshablinsky]

@UniqMartin I modified the options a little, I guess this is all I can do here. It'll output dates in UTC format, but I cannot manage to output it in a more standartised way. Time.parse can interpret almost everything given to it, though, so the change is not very big.

Have you checked what happens when you set, e.g., LC_ALL=de_DE.UTF-8 prior to invocation?

Doesn't change anything.

[UniqMartin]

• I think it would be good to make the pattern ^parent: +\h+ (.+)$ instead of ^parent: *\h* (.*)$. Judging from the example output it seems reasonable to expect that there is always whitespace after the colon, always a hexadecimal ID, and always a non-empty date/time.
• Looking at the example output you provided makes me think we should be parsing the uuid: line instead of the parent: line. I tried to confirm that by searching Fossil's online documentation, but failed to find a definitive answer. Can you check that and/or point me at the relevant documentation?

[vladshablinsky]

@UniqMartin agree on regex.

Thanks a lot about parent and uuid stuff, I can't explain why I wrote parent instead of uuid. It's something wrong with me.

[UniqMartin]

It's something wrong with me.

There's nothing wrong with you! That's just human and happens to all of us all the time. 😸

[UniqMartin]

I modified the options a little, I guess this is all I can do here. It'll output dates in UTC format, but I cannot manage to output it in a more standartised way. Time.parse can interpret almost everything given to it, though, so the change is not very big.

Thanks for checking and adjusting your code where necessary!

Doesn't change anything.

Great! That's reassuring.

[UniqMartin]

👍 Looks good to me; also all of my comments have been addressed.

[xu-cheng]

Thanks everyone.