Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend/ENV/super: set OPENSSL_NO_VENDOR #15613

Merged
merged 1 commit into from Jul 3, 2023
Merged

extend/ENV/super: set OPENSSL_NO_VENDOR #15613

merged 1 commit into from Jul 3, 2023

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Many (~60) formulae in Homebrew/core set this manually to prevent the
openssl Rust crate from vendoring OpenSSL.

Let's make handling this simpler by setting it globally instead.

@carlocab
extend/ENV/super: set OPENSSL_NO_VENDOR
c3be703 
Many (~60) formulae in Homebrew/core set this manually to prevent the
`openssl` Rust crate from vendoring OpenSSL.

Let's make handling this simpler by setting it globally instead.
@carlocab carlocab enabled auto-merge July 1, 2023 08:22
MikeMcQuaid
MikeMcQuaid approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can this get a Ruby comment?

@carlocab carlocab merged commit 9e257fc into Homebrew:master Jul 3, 2023
24 checks passed
@MikeMcQuaid
Copy link
Member

Oops, should have noticed the auto-merge! Wasn't blocking anyway 😁

carlocab added a commit to carlocab/brew that referenced this pull request Jul 4, 2023
@carlocab
extend/ENV/super: add comment for OPENSSL_NO_VENDOR
b214ccd 
This is based on feedback from Homebrew#15613.
@carlocab carlocab mentioned this pull request Jul 4, 2023
Merged
7 tasks
@carlocab carlocab deleted the openssl-no-vendor branch July 4, 2023 08:24
@carlocab
Copy link
Member Author

carlocab commented Jul 4, 2023

#15623

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carlocab @MikeMcQuaid