Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend/ENV/super: add comment for OPENSSL_NO_VENDOR #15623

Merged
merged 1 commit into from Jul 4, 2023
Merged

extend/ENV/super: add comment for OPENSSL_NO_VENDOR #15623

merged 1 commit into from Jul 4, 2023

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Jul 4, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is based on feedback from #15613.

@carlocab carlocab mentioned this pull request Jul 4, 2023
Merged
7 tasks
@carlocab carlocab enabled auto-merge July 4, 2023 08:41
MikeMcQuaid
MikeMcQuaid approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick turnaround @carlocab!

@carlocab carlocab merged commit 00db165 into Homebrew:master Jul 4, 2023
24 checks passed
@carlocab carlocab deleted the openssl-no-vendor-comment branch July 4, 2023 11:01
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carlocab @MikeMcQuaid