Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_repo_license: allow GitHub's IP not permitted error #15915

Merged

Conversation

bayandin
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Continuation of #15909:

  • Catch AuthenticationFailedError in get_repo_license as well.

Tested it by adding to def self.open_rest

raise AuthenticationFailedError.new(
  :env_token,
  "Although you appear to have the correct authorization credentials, the `Shopify` organization has an IP allow list enabled, and your IP address is not permitted to access this resource.",
)

and running brew audit --online --new-formula toxiproxy (from Homebrew/homebrew-core#140255)

@bayandin bayandin changed the title get_repo_license: ignore ip allowlist error get_repo_license: allow GitHub's IP not permitted error Aug 26, 2023
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks again!

@MikeMcQuaid MikeMcQuaid merged commit feef1ae into Homebrew:master Aug 26, 2023
23 of 24 checks passed
@bayandin bayandin deleted the ignore-github-ip-not-permitted-error branch August 26, 2023 18:50
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants