Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_auditor: make Linux-only GCC dep audit non-strict. #15941

Merged
merged 1 commit into from
Sep 3, 2023
Merged

formula_auditor: make Linux-only GCC dep audit non-strict. #15941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions Library/Homebrew/formula_auditor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,16 +445,9 @@ def audit_conflicts

def audit_gcc_dependency
return unless @core_tap
return if !@strict && !(@git && formula.tap.git?) # git log is required for non-strict audit
return unless Homebrew::SimulateSystem.simulating_or_running_on_linux?
return unless linux_only_gcc_dep?(formula)

bad_gcc_dep = @strict || begin
fv = FormulaVersions.new(formula)
fv.formula_at_revision("origin/HEAD") { |prev_f| !linux_only_gcc_dep?(prev_f) }
end
return unless bad_gcc_dep

problem "Formulae in homebrew/core should not have a Linux-only dependency on GCC."
end

Expand Down