Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_auditor: make Linux-only GCC dep audit non-strict. #15941

Merged
merged 1 commit into from Sep 3, 2023
Merged

formula_auditor: make Linux-only GCC dep audit non-strict. #15941

merged 1 commit into from Sep 3, 2023

Conversation

MikeMcQuaid
Copy link
Member

Otherwise we have to run this separately in brew test-bot which is slower and more confusing.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Sep 2, 2023
Merged
@Bo98
Copy link
Member

Bo98 commented Sep 2, 2023 •
edited

Line 451-456 needs removed too as that controls the different --strict behaviour. The return condition removed here is just there to require --git for the non-strict case since it uses FormulaVersions, so the two bits of code work together.

LGTM otherwise

@MikeMcQuaid
formula_auditor: make Linux-only GCC dep audit non-strict.
b594e87 
Otherwise we have to run this separately in `brew test-bot` which is
slower and more confusing.
@MikeMcQuaid MikeMcQuaid force-pushed the audit_gcc_dependency_not_strict branch from 01c3e0f to b594e87 Compare September 3, 2023 01:39
@MikeMcQuaid
Copy link
Member Author

@Bo98 Done, thanks!

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 3, 2023
@MikeMcQuaid MikeMcQuaid merged commit a1269fc into Homebrew:master Sep 3, 2023
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the audit_gcc_dependency_not_strict branch September 3, 2023 13:13
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab Awaiting requested review from carlocab

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @Bo98 @BrewTestBot