Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit_file: check formula path #15948

Merged
merged 2 commits into from
Sep 4, 2023
Merged

audit_file: check formula path #15948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de8eb35
audit_file: check formula path
bayandin Sep 4, 2023
b7cb835
audit_file: fix condition
bayandin Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions Library/Homebrew/formula_auditor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,14 @@
EOS
end
end

return if !formula.core_formula? || formula.path == formula.tap.new_formula_path(formula.name)

problem <<~EOS

Check warning on line 129 in Library/Homebrew/formula_auditor.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/formula_auditor.rb#L129 

Added line #L129 was not covered by tests
Formula is in wrong path:
Expected: #{formula.tap.new_formula_path(formula.name)}
Actual: #{formula.path}
EOS
end

def self.aliases
Expand Down