-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a method for installing fish function files #1615
Conversation
@@ -778,6 +778,14 @@ def var | |||
HOMEBREW_PREFIX+"var" | |||
end | |||
|
|||
# The directory where the formula's fish funcion files should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: function
# installed. | ||
# This is symlinked into `HOMEBREW_PREFIX` after installation or with | ||
# `brew link` for formulae that are not keg-only. | ||
def fish_function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t that be plural like fish_functions
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change this, but it seemed like the convention was singular.
Thanks @bfontaine for the feedback! Do y'all want me to amend this commit, or create new ones? |
What software installs Fish functions and what are they used for? Thanks! |
@MikeMcQuaid Fish shell plugins and frameworks probably use Fish functions, (e.g. oh-my-fish), and they are basically command line commands for the Fish shell. My little project uses a Fish function to override and enhance a command. |
Fish shell allows third-party software vendors to put their own function files in a directory for their software. For brew installed Fish shell, this is /usr/local/share/fish/vendor_functions.d
0f00d85
to
1995f65
Compare
@zachwhaley To make a core change we'll probably want a few example projects rather than just your personal one. Could you link to a few? Thanks! |
@MikeMcQuaid see my comment on PR #1616 Thanks! |
Perfect, thanks for explaining so well. Merging this and would ❤️ PRs for those formulae to use this after that. |
brew tests
with your changes locally?Fish shell allows third-party software vendors to put their own function files in a directory for their software.
For brew installed Fish shell, this is /usr/local/share/fish/vendor_functions.d