Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/uses_from_macos: audit when depends_on :linux #16382

Merged
merged 1 commit into from Dec 31, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 21, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The uses_from_macos DSL is a bit confusing when a formula is depends_on :linux as the formula isn't using anything on macOS.

We've typically have used depends_on "<builtin-macos>" for these formulae which sounds more accurate.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@cho-m
Copy link
Member Author

cho-m commented Dec 30, 2023

There is one potential scenario of adding depends_on :linux to HEAD that this will give a false positive. Though, we may be able to defer handling this if not used in homebrew-core.

@cho-m cho-m force-pushed the uses_from_macos-linux-required branch from d53ef47 to 2f3f017 Compare December 30, 2023 23:30
@cho-m cho-m marked this pull request as ready for review December 30, 2023 23:30
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @cho-m!

@MikeMcQuaid MikeMcQuaid merged commit bc566b5 into Homebrew:master Dec 31, 2023
24 checks passed
@cho-m cho-m deleted the uses_from_macos-linux-required branch December 31, 2023 17:53
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants