Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/mac/hardware/cpu: update M3 values #16393

Merged
merged 1 commit into from Dec 28, 2023
Merged

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I ran brew config locally on an M3 processor and received this value: CPU: 14-core 64-bit dunno. I checked my hw.cpufamily using sysctl -a: hw.cpufamily: 1912690738. Converting this to hex results in the change I've pushed here. This change returns the correct value: CPU: 14-core 64-bit arm_everest_sawtooth

@p-linnane p-linnane mentioned this pull request Dec 23, 2023
7 tasks
@Bo98
Copy link
Member

Bo98 commented Dec 23, 2023

Hmm ok seems like there's some unclarity here. Apple might have changed their naming system.

The values are:

#define CPUFAMILY_ARM_EVEREST_SAWTOOTH  0x8765edea
#define CPUFAMILY_ARM_IBIZA             0xfa33415e
#define CPUFAMILY_ARM_PALMA             0x72015832
#define CPUFAMILY_ARM_COLL              0x2876f5b5
#define CPUFAMILY_ARM_LOBOS             0x5f4dea93

Coll I think is Apple A17 Pro so can be ignored.

I think perhaps:
M3 = Ibiza
M3 Pro = Lobos
M3 Max = Palma

Is Everest Sawtooth used anywhere for M3? Previous PR linked to commits with that but I wonder if it's only used for A16 on iOS (M3 is believed to be based on A16).

The latest XNU open source unfortunately doesn't have the M3 processors yet.

@p-linnane
Copy link
Member Author

Is Everest Sawtooth used anywhere for M3? Previous PR linked to commits with that but I wonder if it's only used for A16 on iOS (M3 is believed to be based on A16).

I haven't found anything conclusive on that front. I am on M3 Max, which correlates to what you've found.

@p-linnane
Copy link
Member Author

@EricFromCanada let me know that M3 Pro is 0x5f4dea93, so your theory appears to be correct. I'll make adjustments to this PR to reflect this.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!`

@Bo98 Bo98 merged commit e794b99 into Homebrew:master Dec 28, 2023
24 checks passed
@p-linnane p-linnane deleted the m3-update branch December 28, 2023 18:19
@p-linnane p-linnane changed the title os/mac/hardware/cpu: update M3 value os/mac/hardware/cpu: update M3 values Dec 28, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants