Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/hardware/cpu_spec: add M3 values #16437

Merged
merged 2 commits into from Jan 6, 2024
Merged

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Companion to #16393. M3 CPU's are not categorized in the same way previous generations have been.

@Bo98
Copy link
Member

Bo98 commented Jan 6, 2024

Maybe should have at least a comment in os/mac/hardware to point towards needing to update this

@p-linnane
Copy link
Member Author

Done!

@p-linnane p-linnane merged commit 3821fab into Homebrew:master Jan 6, 2024
24 checks passed
@p-linnane p-linnane deleted the m3-cpu-spec branch January 6, 2024 17:12
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants