Add option to retain tmpdir on pr-pull #16530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option will be used to generate build provenance in the `publish-commit-bottles.yml` workflow in `Homebrew/homebrew-core`. It adds a single flag that controls whether or not the temporary directory where bottles are downloaded is retained.
6 tasks
Co-authored-by: Bo Anderson <mail@boanderson.me>
|
I am not sure exactly how I can test this change before merging, so please let me know if you have any ideas! |
| @@ -501,6 +504,15 @@ def self.pr_pull | |||
| upload_args << "--root-url-using=#{args.root_url_using}" if args.root_url_using | |||
| safe_system HOMEBREW_BREW_FILE, *upload_args | |||
| end | |||
| ensure | |||
| if args.retain_bottle_dir? && ENV["GITHUB_ACTIONS"] | |||
| ohai "Bottle files retained at:", dir | |||
There was a problem hiding this comment.
Suggested change
| ohai "Bottle files retained at:", dir | |
| ohai "Bottle files retained at: #{dir}" |
Nit: style
brew(main):003:0> dir = "/tmp"
=> "/tmp"
brew(main):004:0> ohai "Bottle files retained at:", dir
==> Bottle files retained at:
/tmp
=> nil
brew(main):005:0> ohai "Bottle files retained at: #{dir}"
==> Bottle files retained at: /tmp
=> nilThis makes sure the output stays on one line.
There was a problem hiding this comment.
@apainintheneck ohai will truncate long output and doesn't need the colon if on one line so I think this is actually better as-is.
MikeMcQuaid
approved these changes
Jan 26, 2024
| @@ -501,6 +504,15 @@ def self.pr_pull | |||
| upload_args << "--root-url-using=#{args.root_url_using}" if args.root_url_using | |||
| safe_system HOMEBREW_BREW_FILE, *upload_args | |||
| end | |||
| ensure | |||
| if args.retain_bottle_dir? && ENV["GITHUB_ACTIONS"] | |||
| ohai "Bottle files retained at:", dir | |||
There was a problem hiding this comment.
@apainintheneck ohai will truncate long output and doesn't need the colon if on one line so I think this is actually better as-is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option will be used to generate build provenance in the
publish-commit-bottles.ymlworkflow inHomebrew/homebrew-core. It adds a single flag that controls whether or not the temporary directory where bottles are downloaded is retained.Necessary for adding build provenance to
Homebrew/homebrew-core. This must be merged first.brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?